Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: run ./maintainers/scripts/update_redirected_urls.sh #105101

Merged
merged 2 commits into from Nov 27, 2020
Merged

treewide: run ./maintainers/scripts/update_redirected_urls.sh #105101

merged 2 commits into from Nov 27, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#101464

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

already got a conflict :(

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Nov 27, 2020 •
edited

already got a conflict :(

That took like 2 minutes. Going to merge it asap when I fixed that.

Edit: I think I know why: I did not fetch the other PR I linked as motivation. Classical derp.

@SuperSandro2000 SuperSandro2000 merged commit 9993ffb into NixOS:master Nov 27, 2020
@SuperSandro2000 SuperSandro2000 deleted the update-url-redirects branch November 27, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@stigtsp stigtsp Awaiting requested review from stigtsp

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @jonringer