Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ytt: init at 0.30.0 #105071

Merged
merged 2 commits into from Dec 3, 2020
Merged

ytt: init at 0.30.0 #105071

merged 2 commits into from Dec 3, 2020

Conversation

brhoades
Copy link
Member

https://github.com/vmware-tanzu/carvel-ytt

Motivation for this change

ytt is not already available in nixpkgs. Tests ran by checkPhase fail due to YAML marshaling issues but failures are unrelated to the result binary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

wilsonehusin
wilsonehusin approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@wilsonehusin wilsonehusin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofborg ofborg bot requested a review from kalbasit November 26, 2020 20:34
SuperSandro2000
SuperSandro2000 requested changes Nov 26, 2020
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/tools/ytt/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/ytt/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/ytt/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/ytt/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/ytt/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
SuperSandro2000
SuperSandro2000 requested changes Nov 28, 2020
View reviewed changes
pkgs/development/tools/ytt/default.nix Show resolved Hide resolved
pkgs/development/tools/ytt/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/ytt/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105071 run on x86_64-linux 1

1 package built:
  • ytt

@brhoades brhoades changed the title ytt init at v0.30.0 ytt: init at v0.30.0 Dec 2, 2020
SuperSandro2000
SuperSandro2000 reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the title and commit message to not contain a v in the version number.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105071 run on x86_64-linux 1

1 package built:
  • ytt

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105071 run on x86_64-darwin 1

1 package built:
  • ytt

@brhoades brhoades changed the title ytt: init at v0.30.0 ytt: init at 0.30.0 Dec 3, 2020
@brhoades
ytt: init at 0.30.0
608665f 
Added carvel ytt 0.30.0 which is currently absent. Tests ran by
checkPhase currently fail due to YAML marshalling problems, but the tool
itself appears fine.
@brhoades
Copy link
Member Author

brhoades commented Dec 3, 2020

Change the title and commit.

@SuperSandro2000
Copy link
Member

Congratulations on your first PR.

@SuperSandro2000 SuperSandro2000 merged commit 178a44c into NixOS:master Dec 3, 2020
@brhoades
Copy link
Member Author

brhoades commented Dec 3, 2020

Thanks for the assistance!

@brhoades brhoades mentioned this pull request Dec 12, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@wilsonehusin wilsonehusin wilsonehusin approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brhoades @SuperSandro2000 @wilsonehusin @Janik-Haag