python3Packages.py-air-control: init at 2.1.0 #105078

urbas · 2020-11-26T21:05:53Z

Motivation for this change

This Python package was not yet packaged in nixpkgs.

Package size:

$ nix path-info -sh $(nix-build . -A python3Packages.py-air-control)
/nix/store/07ssfnqs4gp89pscij442nd51bvdj771-python3.8-py-air-control-2.1.0       116.9K

Things done

cc @SuperSandro2000

SuperSandro2000

Please disable it on python27 and disable the tests because the package has none.

running egg_info
writing py_air_control.egg-info/PKG-INFO
writing dependency_links to py_air_control.egg-info/dependency_links.txt
writing entry points to py_air_control.egg-info/entry_points.txt
writing requirements to py_air_control.egg-info/requires.txt
writing top-level names to py_air_control.egg-info/top_level.txt
reading manifest file 'py_air_control.egg-info/SOURCES.txt'
writing manifest file 'py_air_control.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
Finished executing setuptoolsCheckPhase

urbas · 2020-11-26T22:32:02Z

@SuperSandro2000: disabled the tests and disabled on python27.

I also took the liberty and did the same for the coapthon3 package (which I added recently). I did so in separate commits though.

lukegb

A few things to ask you...

pkgs/development/python-modules/coapthon3/default.nix

pkgs/development/python-modules/py-air-control/default.nix

pkgs/top-level/python-packages.nix

lukegb · 2020-11-27T03:07:25Z

pkgs/development/python-modules/py-air-control/default.nix

@@ -0,0 +1,23 @@
+{ buildPythonPackage, coapthon3, fetchPypi, lib, pycryptodomex }:


Is this useful as a Python module, or is it an application (i.e. is it really just for the "airctrl" CLI)?

If the former, this is great :)

If the latter, consider putting this elsewhere in the tree and then using "python3Packages.callPackage" from "all-packages.nix" instead.

It's the former.

To give more context: I am using py-air-control as a library in another Python module. Here's an example of how it's used.

The final goal is to continuously measure air quality, publish the measurements to Prometheus, and visualize in Grafana (all in NixOS on a Raspberry Pi). I hope this makes sense.

Sure! Nice :)

(ooh, I really want to start doing air quality measurement...)

pkgs/development/python-modules/py-air-control/default.nix

SuperSandro2000 · 2020-11-28T17:10:49Z

On darwin it gets stuck at

[1/0/5 built, 0.0 MiB DL] building python3.7-CoAPthon3-1.0.1 (pytestCheckPhase): ======================= 38 failed, 2 deselected in 2.36s =======================

SuperSandro2000 · 2020-11-28T17:48:01Z

Result of nixpkgs-review pr 105078 run on x86_64-linux 1

4 packages built:

python37Packages.coapthon3
python37Packages.py-air-control
python38Packages.coapthon3
python38Packages.py-air-control

urbas · 2020-11-28T22:28:15Z

On darwin it gets stuck at

[1/0/5 built, 0.0 MiB DL] building python3.7-CoAPthon3-1.0.1 (pytestCheckPhase): ======================= 38 failed, 2 deselected in 2.36s =======================

I have seen this happen on x86 before I disabled the two failing tests. I think there's something wrong with the tear-down logic when tests fail.

Tests create some servers, which in turn create a bunch of threads. Maybe the failed tests leave behind some lingering non-daemon threads which prevent pytest to shut down properly.

In any case, since all these tests fail on darwin and they take more than 10 minutes I will just disable them.

I will try to contribute some fast and robust unit tests to both coapthon3 and py-air-control projects. We can then invoke only the unit tests rather than these slow and brittle integration tests.

urbas · 2020-11-28T23:01:33Z

Btw, I now also verified this builds on aarch64 (NixOS on Raspberry Pi 4).

Edit: Also verified it actually works on aarch64 too (got the whole thing up and running with metrics scraped by Prometheus and visualised in Grafana).

lukegb · 2020-12-01T18:53:30Z

Result of nixpkgs-review pr 105078 run on x86_64-linux 1

4 packages built:

python37Packages.coapthon3
python37Packages.py-air-control
python38Packages.coapthon3
python38Packages.py-air-control

SuperSandro2000 · 2020-12-02T09:17:49Z

Tests create some servers, which in turn create a bunch of threads. Maybe the failed tests leave behind some lingering non-daemon threads which prevent pytest to shut down properly.

In any case, since all these tests fail on darwin and they take more than 10 minutes I will just disable them.

Yeah, we do not want to waste reviewers and builders time with that.

I will try to contribute some fast and robust unit tests to both coapthon3 and py-air-control projects. We can then invoke only the unit tests rather than these slow and brittle integration tests.

This won't block the PR but great that you try to improve the project.

SuperSandro2000 · 2020-12-02T10:56:48Z

@urbas I think we need to do the same with the other package.

[1/1/5 built, 2 copied (71.0/71.0 MiB), 19.3 MiB DL] building python3.7-py-air-control-2.1.0 (pytestCheckPhase): ====================== 12 deselected, 20 errors in 1.84s ==================

urbas · 2020-12-02T19:38:15Z

@urbas I think we need to do the same with the other package.

[1/1/5 built, 2 copied (71.0/71.0 MiB), 19.3 MiB DL] building python3.7-py-air-control-2.1.0 (pytestCheckPhase): ====================== 12 deselected, 20 errors in 1.84s ==================

Oh smokes, I hoped at least those would pass. I disabled them now. 👍

SuperSandro2000 · 2020-12-03T09:52:32Z

Result of nixpkgs-review pr 105078 run on x86_64-linux 1

6 packages built:

python37Packages.coapthon3
python37Packages.py-air-control
python38Packages.coapthon3
python38Packages.py-air-control
python39Packages.coapthon3
python39Packages.py-air-control

SuperSandro2000 · 2020-12-03T16:51:07Z

Result of nixpkgs-review pr 105078 run on x86_64-darwin 1

6 packages built:

python37Packages.coapthon3
python37Packages.py-air-control
python38Packages.coapthon3
python38Packages.py-air-control
python39Packages.coapthon3
python39Packages.py-air-control

urbas requested review from FRidh and jonringer as code owners November 26, 2020 21:05

ofborg bot added 6.topic: python 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 26, 2020

SuperSandro2000 requested changes Nov 26, 2020

View reviewed changes

urbas force-pushed the py-air-control branch from c7536c1 to 8660cd6 Compare November 26, 2020 22:30

ofborg bot added the 8.has: clean-up label Nov 26, 2020

urbas requested a review from SuperSandro2000 November 26, 2020 22:47

lukegb requested changes Nov 27, 2020

View reviewed changes

urbas force-pushed the py-air-control branch from 8660cd6 to 5af24e7 Compare November 27, 2020 19:08

jonringer reviewed Nov 27, 2020

View reviewed changes

pkgs/development/python-modules/py-air-control/default.nix Show resolved Hide resolved

urbas force-pushed the py-air-control branch from 5af24e7 to f9a4b59 Compare November 27, 2020 20:57

urbas requested a review from jonringer November 27, 2020 21:27

urbas force-pushed the py-air-control branch from f9a4b59 to eb1e14f Compare November 28, 2020 22:41

lukegb approved these changes Dec 1, 2020

View reviewed changes

urbas added 3 commits December 2, 2020 19:31

python3Packages.py-air-control: init at 2.1.0

6c86b39

python3Packages.coapthon3: disabled tests

2535a09

python3Packages.coapthon3: disabled for Python 2.7

b4c38bc

urbas force-pushed the py-air-control branch from eb1e14f to b4c38bc Compare December 2, 2020 19:32

SuperSandro2000 merged commit 879cea8 into NixOS:master Dec 3, 2020

urbas deleted the py-air-control branch December 5, 2020 12:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python3Packages.py-air-control: init at 2.1.0 #105078

python3Packages.py-air-control: init at 2.1.0 #105078

urbas commented Nov 26, 2020 •

edited

SuperSandro2000 left a comment

urbas commented Nov 26, 2020 •

edited

lukegb left a comment

lukegb Nov 27, 2020

urbas Nov 27, 2020

lukegb Nov 27, 2020

SuperSandro2000 commented Nov 28, 2020

SuperSandro2000 commented Nov 28, 2020

urbas commented Nov 28, 2020 •

edited

urbas commented Nov 28, 2020 •

edited

lukegb commented Dec 1, 2020

SuperSandro2000 commented Dec 2, 2020

SuperSandro2000 commented Dec 2, 2020

urbas commented Dec 2, 2020

SuperSandro2000 commented Dec 3, 2020

SuperSandro2000 commented Dec 3, 2020

		@@ -0,0 +1,23 @@
		{ buildPythonPackage, coapthon3, fetchPypi, lib, pycryptodomex }:

python3Packages.py-air-control: init at 2.1.0 #105078

python3Packages.py-air-control: init at 2.1.0 #105078

Conversation

urbas commented Nov 26, 2020 • edited

Motivation for this change

Things done

SuperSandro2000 left a comment

Choose a reason for hiding this comment

urbas commented Nov 26, 2020 • edited

lukegb left a comment

Choose a reason for hiding this comment

lukegb Nov 27, 2020

Choose a reason for hiding this comment

urbas Nov 27, 2020

Choose a reason for hiding this comment

lukegb Nov 27, 2020

Choose a reason for hiding this comment

SuperSandro2000 commented Nov 28, 2020

SuperSandro2000 commented Nov 28, 2020

urbas commented Nov 28, 2020 • edited

urbas commented Nov 28, 2020 • edited

lukegb commented Dec 1, 2020

SuperSandro2000 commented Dec 2, 2020

SuperSandro2000 commented Dec 2, 2020

urbas commented Dec 2, 2020

SuperSandro2000 commented Dec 3, 2020

SuperSandro2000 commented Dec 3, 2020

urbas commented Nov 26, 2020 •

edited

urbas commented Nov 26, 2020 •

edited

urbas commented Nov 28, 2020 •

edited

urbas commented Nov 28, 2020 •

edited