Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.cryptography: mark insecure, CVE-2020-25659 #104726

Merged
merged 1 commit into from Nov 24, 2020
Merged

python2Packages.cryptography: mark insecure, CVE-2020-25659 #104726

merged 1 commit into from Nov 24, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 24, 2020 •
edited

Motivation for this change

closes: #101964

$ nix-build -A pythonPackages.cryptography
error: Package ‘python2.7-cryptography-2.9.2’ in /home/jon/projects/nixpkgs/pkgs/development/python-modules/cryptography/2.9.nix:60 is marked as insecure, refusing to evaluate.


Known issues:
 - CVE-2020-25659
 - https://github.com/advisories/GHSA-hggm-jpg3-v476

You can install it anyway by whitelisting this package, using the
following methods:
...
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

lukegb
lukegb approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@lukegb lukegb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good cleanup effort on #101964 :)

@primeos primeos mentioned this pull request Nov 24, 2020
Closed
10 tasks
@FRidh FRidh merged commit 2545e3f into NixOS:master Nov 24, 2020
@jonringer jonringer deleted the mark-py2-cryptography-insecure branch November 24, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@primeos primeos primeos approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert remaining python2 applications over to python3
5 participants
@jonringer @lukegb @SuperSandro2000 @primeos @FRidh