nixos/locate: Fix sshfs exclusion #104727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes merging less painful. This is nixfmt's preferred format.
SuperSandro2000
approved these changes
Nov 24, 2020
|
I felt bad not checking the "Tested via one or more NixOS test(s)" box, so I made a locate test and verified this sshfs change. @SuperSandro2000 , who already reviewed this: Would you prefer that I bring the test into this PR, or create a separate PR for it? |
|
I think you can just add it to this PR. It fits topic wise and please don't feel bad. Having tests is nice and for some things a must have but I think I'm this case it is nice to have. |
chkno
force-pushed
the
fuse-dot-sshfs
branch
from
e394d1a
to
3dd6ba3
Compare
|
Ok. Now with tests! |
|
@GrahamcOfBorg test locate |
|
hmmm the test probably needs an entry in nixos/tests/all-tests.nix |
The "fuse" and "sshfs" entries already present are not keeping this find invocation out of sshfs mounts, which present as fstype "fuse.sshfs"
chkno
force-pushed
the
fuse-dot-sshfs
branch
from
3dd6ba3
to
86f0dc2
Compare
|
nixos/tests/all-tests.nix entry added. |
|
@GrahamcOfBorg test locate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
locate should not index sshfs mounts. These are already intended to be excluded. Fix the mechanism so they're actually excluded.
Things done
sandboxinnix.confon non-NixOS linux)