Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos.postfix: make postfix.enableSmtp work again #104721

Merged
merged 1 commit into from Nov 24, 2020
Merged

nixos.postfix: make postfix.enableSmtp work again #104721

merged 1 commit into from Nov 24, 2020

Conversation

vkleen
Copy link
Contributor

@vkleen vkleen commented Nov 23, 2020 •
edited by SuperSandro2000

Motivation for this change

This should fix issue #104715. This has been running on my mailserver for a year at least without issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vkleen vkleen requested a review from peti as a code owner November 23, 2020 23:47
@peti peti merged commit 58f29d3 into NixOS:master Nov 24, 2020
@ymarkus ymarkus mentioned this pull request Nov 24, 2020
Merged
10 tasks
@ymarkus
Copy link
Contributor

ymarkus commented Nov 24, 2020

Thank you! Works for me, so I've opened a backport PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti peti is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vkleen @ymarkus @peti