Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyqtgraph: convert to pyqt5 #104728

Merged
merged 1 commit into from Nov 24, 2020
Merged

pythonPackages.pyqtgraph: convert to pyqt5 #104728

merged 1 commit into from Nov 24, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Update pythonPackages.pyqtgraph to use pyqt5 instead of pyqt4.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Nov 24, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick: It would be nice if you could try to minimize the diff and remove changes which are not necessary.

@drewrisinger
Copy link
Contributor Author

@SuperSandro2000 are you requesting a separate formatting commit? because this is bringing pythonPackages.pyqtgraph in line with the convention of alphabetized inputs.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 are you requesting a separate formatting commit? because this is bringing pythonPackages.pyqtgraph in line with the convention of alphabetized inputs.

Oh, nvm. I thought this where changes from testing but sorting is fine.

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 104728 1

1 package failed to build:
  • tribler
12 packages built:
  • cq-editor
  • inkcut
  • python27Packages.binwalk-full
  • python27Packages.pyqtgraph
  • python37Packages.binwalk-full
  • python37Packages.enamlx
  • python37Packages.pyqtgraph
  • python37Packages.stytra
  • python38Packages.binwalk-full
  • python38Packages.enamlx
  • python38Packages.pyqtgraph
  • python38Packages.stytra

jonringer
jonringer approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/104728
1 package failed to build:
tribler

12 packages built:
cq-editor inkcut python27Packages.binwalk-full python27Packages.pyqtgraph python37Packages.binwalk-full python37Packages.enamlx python37Packages.pyqtgraph python37Packages.stytra python38Packages.binwalk-full python38Packages.enamlx python38Packages.pyqtgraph python38Packages.stytra

@jonringer jonringer merged commit e9a5187 into NixOS:master Nov 24, 2020
@drewrisinger
Copy link
Contributor Author

The tribler breakage is due to pytest-testmon being broken.

@drewrisinger drewrisinger deleted the dr-pr-pyqtgraph-0_11 branch November 24, 2020 15:00
@drewrisinger drewrisinger mentioned this pull request Nov 24, 2020
Closed
@drewrisinger
Copy link
Contributor Author

I'm considering backporting this to nixos-20.03 or nixos-20.09. The last update to pythonPackages.pyqt4 was in 2015 (according to pypi), so I think this change should very stable.

Can I get thoughts before opening a PR?

@SuperSandro2000
Copy link
Member

I would only backport it to nixos-20.09.

@drewrisinger drewrisinger mentioned this pull request Nov 30, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drewrisinger @SuperSandro2000 @RaghavSood @jonringer