Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv: 0.32.0 -> 0.33.0 #104716

Merged
merged 1 commit into from Nov 24, 2020
Merged

mpv: 0.32.0 -> 0.33.0 #104716

merged 1 commit into from Nov 24, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 23, 2020

Motivation for this change

https://github.com/mpv-player/mpv/releases/tag/v0.33.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 104716 1

1 package failed to build:
  • mpc-qt
17 packages built:
  • celluloid
  • curseradio
  • jellyfin-mpv-shim
  • jftui
  • minitube
  • mpv
  • mpv-unwrapped
  • mpvScripts.autoload
  • mpvScripts.mpris
  • plex-media-player
  • plex-mpv-shim
  • python37Packages.mpv
  • python38Packages.mpv
  • qimgv
  • somafm-cli
  • sublime-music
  • tuijam

, screenSaverSupport ? true, libXScrnSaver ? null
, sdl2Support ? true, SDL2 ? null
, sndioSupport ? true, sndio ? null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this removed upstream?

@AndersonTorres
Copy link
Member

I tested mpc-qt locally. No problems here.

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, LGTBorg.

@AndersonTorres AndersonTorres merged commit f30a877 into NixOS:master Nov 24, 2020
@Ma27 Ma27 deleted the bump-mpv branch November 24, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants