Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.lists.unique: Switch from recursive function to using a fold #104744

Merged
merged 1 commit into from Nov 24, 2020
Merged

lib.lists.unique: Switch from recursive function to using a fold #104744

merged 1 commit into from Nov 24, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Nov 24, 2020 •
edited

Motivation for this change

This improves performance by ~30-40% for smaller test cases and makes larger cases where my laptop would OOM pass in seconds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis marked this pull request as draft November 24, 2020 05:25
@adisbladis adisbladis marked this pull request as ready for review November 24, 2020 11:08
infinisil
infinisil requested changes Nov 24, 2020
View reviewed changes
lib/lists.nix Outdated Show resolved Hide resolved
@adisbladis adisbladis force-pushed the unique-foldl branch 2 times, most recently from 6c947f4 to 5a09cda Compare November 24, 2020 13:20
infinisil
infinisil approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@adisbladis
lib.lists.unique: Switch from recursive function to using a fold
85605c8 
This improves performance by ~30-40% for smaller test cases and makes
larger cases where my laptop would OOM pass in seconds.
@adisbladis adisbladis merged commit 04150a0 into NixOS:master Nov 24, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-5/10560/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @nixos-discourse @infinisil