Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.asyncssh: Switch PyTestCheckHook, disable failing tests #104724

Merged
merged 1 commit into from Nov 24, 2020
Merged

pythonPackages.asyncssh: Switch PyTestCheckHook, disable failing tests #104724

merged 1 commit into from Nov 24, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 24, 2020
Merged
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 104724 run on x86_64-linux 1

2 packages built:
  • python37Packages.asyncssh
  • python38Packages.asyncssh

jonringer
jonringer approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 104724 1

2 packages built:
  • python37Packages.asyncssh
  • python38Packages.asyncssh

@jonringer jonringer merged commit abfd29c into NixOS:master Nov 24, 2020
@SuperSandro2000 SuperSandro2000 deleted the asyncssh-disable-failing-tests branch August 26, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @jonringer