Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flood: init at 4.2.0 #104735

Merged
merged 1 commit into from Dec 2, 2020
Merged

flood: init at 4.2.0 #104735

merged 1 commit into from Dec 2, 2020

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Nov 24, 2020 •
edited

Motivation for this change

Second try of this PR: #102552

Using shared node packages now, and also bumping the package to its latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from midchildan November 24, 2020 03:59
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 24, 2020 •
edited

Result of nixpkgs-review pr 104735 run on x86_64-darwin 1

1 package failed to build:
  • lumo
5 packages built:
  • bat-extras.prettybat
  • iosevka
  • vimPlugins.YouCompleteMe
  • vscode-extensions.matklad.rust-analyzer
  • ycmd

lump:

/bin/sh: ./gyp-mac-tool: /usr/bin/env: bad interpreter: Operation not permitted

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 24, 2020 •
edited

Result of nixpkgs-review pr 104735 run on x86_64-linux 1

1 package marked as broken and skipped:
  • rambox-pro
1 package blacklisted:
  • tests.nixos-functions.nixos-test
2 packages failed to build:
  • iosevka
  • lumo
39 packages built:
  • antora
  • bat-extras.prettybat
  • bitwarden-cli
  • castnow
  • create-cycle-app
  • emojione
  • epgstation
  • etcher
  • flood
  • image_optim
  • imgbrd-grabber
  • joplin
  • mastodon-bot
  • mirakurun
  • netlify-cli
  • parity-ui
  • pm2
  • redoc-cli
  • ripcord
  • slack
  • teleprompter
  • thelounge
  • twemoji-color-font
  • vimPlugins.YouCompleteMe
  • vimPlugins.coc-go
  • vimPlugins.coc-html
  • vimPlugins.coc-java
  • vimPlugins.coc-lists
  • vimPlugins.coc-metals
  • vimPlugins.coc-prettier
  • vimPlugins.coc-smartf
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-vetur
  • vimPlugins.coc-yaml
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.vadimcn.vscode-lldb
  • wasm-text-gen
  • yaml-language-server
  • ycmd

The failed builds timed out. Not sure why there should be enough ressources.

@thiagokokada thiagokokada marked this pull request as ready for review November 24, 2020 15:56
@thiagokokada thiagokokada mentioned this pull request Nov 24, 2020
Closed
10 tasks
@ofborg ofborg bot requested a review from midchildan November 24, 2020 17:10
@thiagokokada
Copy link
Contributor Author

Result of nixpkgs-review pr 104735 1

1 package marked as broken and skipped:
  • dat
41 packages built:
  • antora
  • bat-extras.prettybat
  • bitwarden-cli
  • castnow
  • create-cycle-app
  • emojione
  • epgstation
  • etcher
  • flood
  • image_optim
  • imgbrd-grabber
  • iosevka
  • joplin
  • lumo
  • mastodon-bot
  • mirakurun
  • netlify-cli
  • parity-ui
  • pm2
  • redoc-cli
  • ripcord
  • slack (slack-dark)
  • teleprompter
  • thelounge
  • twemoji-color-font
  • vimPlugins.YouCompleteMe
  • vimPlugins.coc-go
  • vimPlugins.coc-html
  • vimPlugins.coc-java
  • vimPlugins.coc-lists
  • vimPlugins.coc-metals
  • vimPlugins.coc-prettier
  • vimPlugins.coc-smartf
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-vetur
  • vimPlugins.coc-yaml
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.vadimcn.vscode-lldb
  • wasm-text-gen
  • yaml-language-server
  • ycmd

@SuperSandro2000
Copy link
Member

@thiagokokada Can you solve the merge conflict?

@thiagokokada
Copy link
Contributor Author

@SuperSandro2000 Yeah, I am working on it. Sadly running generate.sh script (on my machine at least) is pretty slow...

@thiagokokada
Copy link
Contributor Author

@SuperSandro2000 @midchildan rebased again.

@thiagokokada thiagokokada changed the title flood: init at 4.1.2 flood: init at 4.2.0 Dec 1, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 Yeah, I am working on it. Sadly running generate.sh script (on my machine at least) is pretty slow...

It does a lot of network requests. I can also run it and merge it in a few hours after it.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 2, 2020 •
edited

Result of nixpkgs-review pr 104735 run on x86_64-linux 1

2 packages failed to build:
  • iosevka
  • lumo
29 packages built:
  • antora
  • castnow
  • emojione
  • epgstation
  • fast-cli
  • flood
  • gtop
  • image_optim
  • joplin
  • mirakurun
  • netlify-cli
  • pm2
  • postcss-cli
  • redoc-cli
  • ripcord
  • twemoji-color-font
  • vimPlugins.coc-lists
  • vimPlugins.coc-markdownlint
  • vimPlugins.coc-metals
  • vimPlugins.coc-prettier
  • vimPlugins.coc-rust-analyzer
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-tabnine
  • vimPlugins.coc-vetur
  • vimPlugins.coc-yaml
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.ms-python.vscode-pylance
  • vscode-extensions.vadimcn.vscode-lldb
  • yaml-language-server

The failed builds timed out for me.

@SuperSandro2000 SuperSandro2000 merged commit ffe9244 into NixOS:master Dec 2, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 2, 2020 •
edited

Result of nixpkgs-review pr 104735 run on x86_64-darwin 1

1 package failed to build:
  • lumo
2 packages built:
  • iosevka
  • vscode-extensions.matklad.rust-analyzer

lumo: /bin/sh: ./gyp-mac-tool: /usr/bin/env: bad interpreter: Operation not permitted

known problem

@thiagokokada thiagokokada deleted the flood-init-2nd-try branch December 2, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@midchildan midchildan Awaiting requested review from midchildan

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thiagokokada @SuperSandro2000 @midchildan