Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages: unbreak packages #104741

Merged
merged 2 commits into from Nov 25, 2020
Merged

haskellPackages: unbreak packages #104741

merged 2 commits into from Nov 25, 2020

Conversation

svmhdvn
Copy link
Contributor

@svmhdvn svmhdvn commented Nov 24, 2020

Motivation for this change

Helps to close #42780.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

Sorry, looks like there is a conflict with your other PRs. Could you rebase this on top of haskell-updates to get rid of the conflict?

Also, if you know there will be conflicts when sending PRs, feel free to just bunch them all into one big PR. It is not pretty, but it saves us work trying to go back and forth with rebasing and fixing conflicts.

@svmhdvn svmhdvn changed the title haskellPackages.blas-hs: unbreak haskellPackages: unbreak packages Nov 25, 2020
@svmhdvn
Copy link
Contributor Author

svmhdvn commented Nov 25, 2020

Sorry about that! It's been a while since contributing to nixpkgs, I forgot about that. Should be fixed now.

@cdepillabout
Copy link
Member

Thanks for fixing this up, I've confirmed that both of these packages are now building!

@cdepillabout cdepillabout merged commit 8a5e6ea into NixOS:haskell-updates Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svmhdvn @cdepillabout