Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio-experimental, factorio-headless-experimental: 1.0.0 -> 1.1.0 #104725

Merged
merged 1 commit into from Nov 24, 2020
Merged

factorio-experimental, factorio-headless-experimental: 1.0.0 -> 1.1.0 #104725

merged 1 commit into from Nov 24, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Nov 24, 2020

Motivation for this change

Update experimental branch (https://forums.factorio.com/viewtopic.php?f=3&t=91657)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 24, 2020 •
edited 

hash mismatch in fixed-output derivation '/nix/store/ivipxraqpw38zqsqskqcs5fwb10lf4x2-factorio_alpha_x64-1.1.0.tar.xz':
  wanted: sha256:0n00nbh44nyf485jys6pkga3pb9j4zywk0liq6jq99pil6z7na3y
  got:    sha256:0dxi6my1xhwr9178pj13axzhvvn1yc053kc1halc9pl5iqlanipq
cannot build derivation '/nix/store/wpv10mgpja7sdrw3q66h7mpjawcr1yzp-factorio-alpha-1.1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/c0gck6pw770kq1j0j7wg0xdw4xg3554r-env.drv': 1 dependencies couldn't be built

Did they already do the reupload for the failed update package?

Anyway. The factory must grow.

Edit: or this package is not idiot proof. I did not provide any credentials because I am lazy and headless should work without in nixpkgs-review.

@lukegb
Copy link
Contributor Author

lukegb commented Nov 24, 2020

Edit: or this package is not idiot proof. I did not provide any credentials because I am lazy and headless should work without in nixpkgs-review.

Yeah, non-headless needs creds and the f-o error message isn't super helpful...

@ofborg ofborg bot requested review from elitak, erictapen and Baughn November 24, 2020 02:08
erictapen
erictapen approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for me, thanks!

@erictapen erictapen merged commit 0508481 into NixOS:master Nov 24, 2020
@lukegb lukegb deleted the update-factorio-1.1.0 branch November 24, 2020 03:05
elitak
elitak reviewed Nov 24, 2020
View reviewed changes
Copy link
Contributor

@elitak elitak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elitak elitak elitak left review comments

@erictapen erictapen erictapen approved these changes

@Baughn Baughn Awaiting requested review from Baughn

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukegb @SuperSandro2000 @elitak @erictapen