Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clojure/default.nix #103759

Closed
wants to merge 1 commit into from
Closed

Update clojure/default.nix #103759

wants to merge 1 commit into from

Conversation

PlumpMath
Copy link

@PlumpMath PlumpMath commented Nov 14, 2020

reference clojure-tools install.sh

Motivation for this change

use for https://github.com/seancorfield/clj-new
and
https://github.com/clojure/brew-install/blob/1.10.1/CHANGELOG.md

Things done

upgrade 1.10.727 (stable version)
code referenced install.sh clojure-tools's binary

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

reference clojure-tools install.sh
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/maintained-usable-tooling-for-building-clojure-projects-in-nix/1556/11

@dbirks
Copy link
Member

dbirks commented Nov 14, 2020

Thanks for the update! 🧑‍💻

Just wanted to let you know that the commit message will probably need to be changed to fit CONTRIBUTING.md. Probably something like:

clojure: 1.10.1.645 -> 1.10.1.727

@PlumpMath
Copy link
Author

Thanks for the update! 🧑‍💻

Just wanted to let you know that the commit message will probably need to be changed to fit CONTRIBUTING.md. Probably something like:

clojure: 1.10.1.645 -> 1.10.1.727

thank you for telling me. I'll keep mind it next time commit. The problem is, I don't know how to recommit this... absurdly ^,.^; Thanks Thanks good day. =33

@jlesquembre
Copy link
Member

@PlumpMath the changes to want to merge are already on master: 43776fb

If you want to backport the changes to 20.09, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes

I think it would be easier to open a new PR to backport the changes. That's why I'm closing this PR, but feel free to open a new PR

@PlumpMath
Copy link
Author

PlumpMath commented Nov 15, 2020

Thanks @jlesquembre

Before sending PR, do I have to keep the fork in the nixpkgs repository? (and local? push;)
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants