Update Windows install notes #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will look into modifying how cmake handles the ffts include path on windows, so the source files don't need to be changed. |
|
@nshcat - thanks! On IRC, @azonenberg suggested comparing the documented steps vs. CI scripts... I don't have time to do this now unfortunately |
|
@nshcat The GitHub Actions CI build currently works without any patching of code. it's possible the documentation disagrees with the CI build process. |
|
Merging and closing this PR as the requested doc changes are all good. @nshcat The FFTS include path issues are unrelated, file a separate ticket against either scopehal-apps (if bug is on the build system/code side) or scopehal-docs (if build instructions are wrong) once you've investigated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few steps that need revising on the Windows install.
I also noticed that I needed to apply the following fix to all files that use FFTS. I'm not sure how to best document this, and I imagine making this change will affect / break Linux...?