Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fontconfig: build manpages, install them in bin output #103725

Merged
merged 1 commit into from Nov 18, 2020
Merged

fontconfig: build manpages, install them in bin output #103725

merged 1 commit into from Nov 18, 2020

Conversation

erictapen
Copy link
Member

Motivation for this change

Generate manpages for fontconfig and install them in the bin output.

Closes #103695 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat vcunat changed the base branch from master to staging November 14, 2020 18:51
vcunat
vcunat approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, though I'm not sure about the man3 part... perhaps that's not really suitable there. (It's over two hundred pages; there might be noticeable overhead in some cases. And they seem less likely to be useful.)

@ofborg ofborg bot requested a review from vcunat November 14, 2020 19:03
@erictapen
fontconfig: build manpages, install them in bin output
0121b40 
We exclude man3, as it is pretty large and probably not so relevant.
@erictapen
Copy link
Member Author

@vcunat agreed. I removed section 3.

@FRidh FRidh merged commit 6463b27 into NixOS:staging Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fontconfig: missing manpages
3 participants
@erictapen @vcunat @FRidh