Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghidra: 9.1.2 -> 9.2 #103750

Merged
merged 1 commit into from Nov 23, 2020
Merged

ghidra: 9.1.2 -> 9.2 #103750

merged 1 commit into from Nov 23, 2020

Conversation

GovanifY
Copy link
Member

@GovanifY GovanifY commented Nov 13, 2020 •
edited

Motivation for this change

Version bump, also added myself as a maintainer. Depends on #103461 as I added myself to the maintainers-nix in the linked PR but it will probably be merged in the next few hours. Ofborg will fail until this PR is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak reviewed Nov 14, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few suggestions

pkgs/tools/security/ghidra/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/ghidra/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/ghidra/default.nix Outdated Show resolved Hide resolved
@GovanifY
Copy link
Member Author

@ofborg eval

@ofborg ofborg bot requested a review from ck3d November 18, 2020 09:23
@prusnak prusnak merged commit 5b6b477 into NixOS:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@ck3d ck3d Awaiting requested review from ck3d

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GovanifY @prusnak