Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waypoint: init at 0.1.5 #103754

Merged
merged 1 commit into from Dec 21, 2020
Merged

waypoint: init at 0.1.5 #103754

merged 1 commit into from Dec 21, 2020

Conversation

06kellyjac
Copy link
Member

Motivation for this change

Init waypoint at 0.1.5
Based on @winpat's pr #100994
I'm happy for any of my modifications to be coppied over & delete this branch. I'll put a PR in upstream so we can probably use make bin as is.

Resolves the injection issue issue

nixpkgs_waypoint

Removed the dontPatchELF stuff because none of it seems to actually be passed through by buildGoModule and I'm not comfortable changing it.

Things done

I ran the init and the build but it could do with more testing.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and winpat November 14, 2020 00:10
@winpat winpat mentioned this pull request Nov 14, 2020
Closed
10 tasks
@winpat
Copy link
Member

winpat commented Nov 14, 2020

Great job! I closed my PR.

Should be able to test this tomorrow.

@winpat
Copy link
Member

winpat commented Nov 16, 2020

LGTM. All the issues I had with my original expressions are resolved.

@06kellyjac
Copy link
Member Author

It's looking like -static isn't going to be added upstream.
I've tried a bunch of things to get it working without it but no luck so far.

I'm also happy to add back in the git stuff for setting the version if you'd like

@winpat
Copy link
Member

winpat commented Nov 17, 2020

I'm also happy to add back in the git stuff for setting the version if you'd like

That sounds like a good idea.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103754 run on x86_64-linux 1

1 package built:
  • waypoint

@06kellyjac
Copy link
Member Author

@winpat actually it looks like fetchgit with leaveDotGit isn't a great idea in its current state #100498 #64319 (comment)
TIL

@06kellyjac
Copy link
Member Author

Also it doesn't look like there's going to be much progress investigating the issue so I'm happy with it as is & I don't want to keep you and others waiting by leaving this in review if it's working well with everything we've tried so far

@06kellyjac 06kellyjac marked this pull request as ready for review November 29, 2020 16:04
@06kellyjac
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 16, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

vikanezrimaya
vikanezrimaya approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@vikanezrimaya vikanezrimaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, let me tell that I love reviewing Nixpkgs PRs because sometimes I discover a gem of a package that I instantly fall in love with the moment I see it. This is one of these gems.

I've read and followed the tutorial with a Node app while using Waypoint built out of this derivation, and it was seamless. No errors, it works perfectly. LGTM.

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from Ekleog December 16, 2020 22:50
@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 20, 2020

Reminder: Please review!

Reminder: This Pull Request is awaiting merger. If you are the assigned reviewer with commit permission, please have a look. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@06kellyjac @winpat
waypoint: init at 0.1.5
6c83949 
Co-authored-by: Patrick Winter <patrickwinter@posteo.ch>
@06kellyjac
Copy link
Member Author

06kellyjac commented Dec 21, 2020 •
edited

Added the extra flags to reduce size as requested.
Results:

before:
103.4 MB - waypoint
 45.4 MB - waypoint-entrypoint

after:
 90.7 MB - waypoint
 40.3 MB - waypoint-entrypoint

waypoint init and waypoint build still work on the waypoint-example projects (I tried docker/static)

@ofborg ofborg bot requested a review from winpat December 21, 2020 09:44
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103754 run on x86_64-linux 1

1 package built:
  • waypoint

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103754 run on x86_64-darwin 1

@SuperSandro2000 SuperSandro2000 merged commit b333263 into NixOS:master Dec 21, 2020
@06kellyjac 06kellyjac deleted the waypoint branch December 21, 2020 18:17
@06kellyjac 06kellyjac mentioned this pull request Feb 6, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@vikanezrimaya vikanezrimaya vikanezrimaya approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Ekleog Ekleog Awaiting requested review from Ekleog

@winpat winpat Awaiting requested review from winpat

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@06kellyjac @winpat @SuperSandro2000 @vikanezrimaya