Provide libwpe for webkitgtk in Wayland #103728
Closed
+97
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/install-nixos-on-laptop-im-failing-hard/6955/5 |
jtojnar
approved these changes
Nov 13, 2020
Ah I had opened it in #96140 but forgot about it! Anyway this should be find to merge first, especially if it resolves the epiphany on wayland issue. |
| description = "General-purpose library for WPE WebKit"; | ||
| license = licenses.bsd2; | ||
| homepage = "https://wpewebkit.org"; | ||
| maintainers = [ maintainers.matthewbauer ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = [ maintainers.matthewbauer ]; | |
| maintainers = with maintainers; [ matthewbauer ]; |
| description = "Freedesktop.org backend for WPE WebKit"; | ||
| license = licenses.bsd2; | ||
| homepage = "https://wpewebkit.org"; | ||
| maintainers = [ maintainers.matthewbauer ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = [ maintainers.matthewbauer ]; | |
| maintainers = with maintainers; [ matthewbauer ]; |
matthewbauer
force-pushed
the
webkitgtk-with-libwpe
branch
from
182f9c6 to
2377726
Compare
|
Updated |
|
@GrahamcOfBorg build epiphany |
jtojnar
reviewed
Nov 23, 2020
| ]; | ||
|
|
||
| nativeBuildInputs = [ | ||
| pkgconfig |
|
@matthewbauer Can you fix the eval error? |
|
Closing in favor of #96140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in a Wayland environment, webkitgtk needs the libwpe backend to implement accelerated compositing on Wayland. Without this, you can get errors like:
Webkitgtk is supposed to gracefully disable AC when this happens, but this doesn't appear to be working for me. You can manually disable AC with WEBKIT_DISABLE_COMPOSITING_MODE=1.
See https://gitweb.gentoo.org/repo/gentoo.git/tree/net-libs/webkit-gtk/webkit-gtk-2.28.4.ebuild#n222 for some idea of how Gentoo handles this. In nixpkgs, I think it's a good idea to just provide libwpe everywhere, regardless of whether the user has configured "wayland" or not.
Other discussions: