Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zathura: 0.4.5 -> 0.4.7 #103727

Merged
merged 2 commits into from Nov 13, 2020
Merged

zathura: 0.4.5 -> 0.4.7 #103727

merged 2 commits into from Nov 13, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 13, 2020 •
edited

Motivation for this change

fix #100441 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

actually, doesn't fix the problem. But this problem has been identified here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237770

@jonringer
Copy link
Contributor Author

@timokau the pdf-mupdf extension wasn't linking against anything, I fixed that

timokau
timokau approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@jonringer
Copy link
Contributor Author 

https://github.com/NixOS/nixpkgs/pull/103727
1 package built:
zathura

@jonringer jonringer merged commit 6e9b71f into NixOS:master Nov 13, 2020
@jonringer jonringer deleted the bump-zathura branch November 13, 2020 19:01
This was referenced Nov 14, 2020
Closed
Merged
@delroth delroth mentioned this pull request Jun 11, 2023
Merged
12 tasks
@delroth
Copy link
Contributor

delroth commented Jun 11, 2023 •
edited

It turns out that this was probably the wrong fix re: mupdf linking errors: see #237199 which addresses the actual root cause of this issue.

Yes, about 3 years late with that comment, not sure if you want to follow up on this or leave it to the current maintainers :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @delroth @timokau