gping: 1.1 -> 0.1.6 #103767
Merged
gping: 1.1 -> 0.1.6 #103767
+11
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbirks
approved these changes
Nov 14, 2020
There was a problem hiding this comment.
Thanks for the rewrite. I saw a post about it and wanted to give it a try. I can confirm it builds and runs nicely on NixOS:
And it looks like we're unblocked on the licensing issue as of ~5 min ago 🙂
danieldk
suggested changes
Nov 14, 2020
danieldk
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://www.reddit.com/r/rust/comments/jthdba/gping_ping_but_with_a_graph/
gping is now a Rust project.
This is the reason for the apparent "downgrade".
Currently blocked on orf/gping#77