Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate py37 programs to py3 #103742

Merged
merged 6 commits into from Nov 28, 2020
Merged

Migrate py37 programs to py3 #103742

merged 6 commits into from Nov 28, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 13, 2020 •
edited

Motivation for this change

Some programs in nixpkgs were using explicitly python37, and they also work with latest branch, so here are some "migrations" that seem correct.

I started the binaries they look ok

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Scriptkiddi November 13, 2020 22:06
SuperSandro2000
SuperSandro2000 reviewed Nov 23, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated
@@ -937,7 +937,7 @@ in

iamy = callPackage ../tools/admin/iamy { };

azure-cli = callPackage ../tools/admin/azure-cli { python = python37; };
azure-cli = callPackage ../tools/admin/azure-cli { python = python3; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using python3 in the package is probably more straight forward.

@SuperSandro2000
Copy link
Member

When trying to build this with nixpkgs-review I get several thousands rebuilds. Not sure what went wrong here.

@freezeboy
Copy link
Contributor Author

@SuperSandro2000 azure-cli has its own package set.. maybe redundant with other azure-* packages by the way

@jonringer Do you know why there is a special python-package set ?

@freezeboy freezeboy mentioned this pull request Nov 24, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from jonringer November 24, 2020 17:56
@jonringer
Copy link
Contributor

@jonringer Do you know why there is a special python-package set ?

because the azure-cli lags 1-6 weeks behind most of the python azure sdk, or sometimes uses pre-releases for certain packages. azure-cli would essentially be unusable without it.

@jonringer
Copy link
Contributor

azure-cli was kept at python37 originally because aiohttp didn't support it for the longest time

@freezeboy
Copy link
Contributor Author

ok good to know

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 28, 2020 •
edited

Result of nixpkgs-review pr 103742 run on x86_64-darwin 1

4 packages failed to build:
  • azure-cli
  • html5validator
  • manim
  • precice

manim download over 3000 tex packages. Not trying this one. Other are currently building manually to get some logs.

Edit: rebuild everything except mannim and it worked.

jonringer
jonringer approved these changes Nov 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 103742 1

5 packages built:
  • azure-cli
  • html5validator
  • manim
  • precice
  • syncplay

@jonringer jonringer merged commit abfbb84 into NixOS:master Nov 28, 2020
@freezeboy freezeboy deleted the migrate-py37-py3 branch November 28, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer jonringer approved these changes

@Scriptkiddi Scriptkiddi Awaiting requested review from Scriptkiddi

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @SuperSandro2000 @jonringer