Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave: 1.16.72 -> 1.16.76 #103757

Merged
merged 1 commit into from Nov 21, 2020
Merged

Brave: 1.16.72 -> 1.16.76 #103757

merged 1 commit into from Nov 21, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Nov 14, 2020 •
edited

Motivation for this change

Browsers need to be up-to-date at all times. Brave is no exception.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JeffLabonte JeffLabonte marked this pull request as draft November 14, 2020 00:45
@JeffLabonte JeffLabonte marked this pull request as ready for review November 14, 2020 00:46
@ofborg ofborg bot requested review from uskudnik and rht November 14, 2020 01:14
dbirks
dbirks approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@dbirks dbirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that it builds and runs for me on NixOS.

image

@buckley310
Copy link
Contributor

Works for me too. This update contains some big security fixes.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/289

@AndersonTorres AndersonTorres merged commit d877232 into NixOS:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbirks dbirks dbirks approved these changes

@uskudnik uskudnik Awaiting requested review from uskudnik

@rht rht Awaiting requested review from rht

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JeffLabonte @buckley310 @nixos-discourse @dbirks @AndersonTorres