Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libreoffice-qt: wrap application #103734

Merged
merged 1 commit into from Nov 14, 2020
Merged

libreoffice-qt: wrap application #103734

merged 1 commit into from Nov 14, 2020

Conversation

jmpunkt
Copy link
Contributor

@jmpunkt jmpunkt commented Nov 13, 2020

Libreoffice-qt is not wrapped, thus does not launch. Notice that
wrapQtQAppsHook is used manually since all executables are shell
scripts which are not wrapped automatically.

Motivation for this change

Libreoffice-qt currently does not start on 20.09 or master due to missing Qt wrapping.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jmpunkt
libreoffice-qt: wrap application
ea12d88 
Libreoffice-qt is not wrapped, thus does not launch. Notice that
wrapQtQAppsHook is used manually since all executables are shell
scripts which are not wrapped automatically.
@ofborg ofborg bot requested a review from 7c6f434c November 13, 2020 20:15
@7c6f434c 7c6f434c merged commit e3a8851 into NixOS:master Nov 14, 2020
@jmpunkt jmpunkt deleted the libreoffice-qt-wrap branch November 14, 2020 17:06
@jmpunkt jmpunkt mentioned this pull request Nov 14, 2020
Merged
10 tasks
@7c6f434c 7c6f434c mentioned this pull request Nov 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmpunkt @7c6f434c