Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cask: Enable on more platforms than Linux #105274

Merged
merged 1 commit into from Nov 28, 2020
Merged

cask: Enable on more platforms than Linux #105274

merged 1 commit into from Nov 28, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Nov 28, 2020

Motivation for this change

It seems to work fine on macOS. So it would be nice to have it there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu requested a review from adisbladis November 28, 2020 18:52
@adisbladis adisbladis merged commit d5d9e31 into NixOS:master Nov 28, 2020
@etu etu deleted the cask-platforms branch November 28, 2020 18:53
@ofborg ofborg bot requested a review from FlexW November 28, 2020 19:02
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105274 run on x86_64-darwin 1

1 package built:
  • cask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@FlexW FlexW Awaiting requested review from FlexW

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @SuperSandro2000 @adisbladis