Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxml2: upstream patch for Python 3.9. #105268

Merged
merged 1 commit into from Dec 9, 2020
Merged

libxml2: upstream patch for Python 3.9. #105268

merged 1 commit into from Dec 9, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 28, 2020

(cherry picked from commit 81eddf1)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member Author

FRidh commented Nov 28, 2020

Please don't merge until we have a batch of changes for staging-20.09.

@ofborg ofborg bot requested a review from edolstra November 28, 2020 18:20
@mweinelt mweinelt added this to Ready in Staging (stable) Dec 8, 2020
@mweinelt
Copy link
Member

mweinelt commented Dec 9, 2020

@FRidh Is this ready to go in? Asking because #106447 just went in.

@FRidh FRidh marked this pull request as ready for review December 9, 2020 16:30
@FRidh
Copy link
Member Author

FRidh commented Dec 9, 2020

yes definitely

@mweinelt mweinelt merged commit 9fbf85c into NixOS:staging-20.09 Dec 9, 2020
Staging (stable) automation moved this from Ready to Done Dec 9, 2020
@FRidh FRidh deleted the libxml2 branch December 9, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging (stable)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @mweinelt @dhess