Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.vendor-reset: init at 0.0.18 #105280

Closed
wants to merge 1 commit into from
Closed

linuxPackages.vendor-reset: init at 0.0.18 #105280

wants to merge 1 commit into from

Conversation

Chiiruno
Copy link
Contributor

Motivation for this change

Fix reset issues for those using VFIO.
No official releases yet, but not tagged as unstable due to gnif/vendor-reset#2 and gnif/vendor-reset@a6458b3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105280 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.vendor-reset
  • linuxPackages_hardkernel_latest.vendor-reset
4 packages failed to build:
  • linuxPackages_4_14.vendor-reset
  • linuxPackages_4_19.vendor-reset
  • linuxPackages_4_4.vendor-reset
  • linuxPackages_4_9.vendor-reset
13 packages built:
  • linuxPackages-libre.vendor-reset
  • linuxPackages.vendor-reset (linuxPackages_5_4.vendor-reset)
  • linuxPackages_5_8.vendor-reset
  • linuxPackages_5_9.vendor-reset (linuxPackages_latest.vendor-reset)
  • linuxPackages_hardened.vendor-reset
  • linuxPackages_latest-libre.vendor-reset
  • linuxPackages_latest_hardened.vendor-reset
  • linuxPackages_latest_xen_dom0.vendor-reset
  • linuxPackages_latest_xen_dom0_hardened.vendor-reset
  • linuxPackages_testing_bcachefs.vendor-reset
  • linuxPackages_xen_dom0.vendor-reset
  • linuxPackages_xen_dom0_hardened.vendor-reset
  • linuxPackages_zen.vendor-reset

@Chiiruno
Copy link
Contributor Author

My bad, should work now.

@lukegb
Copy link
Contributor

lukegb commented Nov 29, 2020

The PR name (and commit description) should have "linuxPackages.vendor-reset" and not just "vendor-reset", I think, to make ofBorg do the right thing.

@ofborg build linuxPackages_4_14.vendor-reset linuxPackages_4_19.vendor-reset linuxPackages_4_4.vendor-reset linuxPackages_4_9.vendor-reset linuxPackages.vendor-reset linuxPackages_latest.vendor-reset

@lukegb
Copy link
Contributor

lukegb commented Nov 29, 2020

Result of nixpkgs-review pr 105280 1

13 packages built:
  • linuxPackages-libre.vendor-reset
  • linuxPackages.vendor-reset (linuxPackages_5_4.vendor-reset)
  • linuxPackages_5_8.vendor-reset
  • linuxPackages_5_9.vendor-reset (linuxPackages_latest.vendor-reset)
  • linuxPackages_hardened.vendor-reset
  • linuxPackages_latest-libre.vendor-reset
  • linuxPackages_latest_hardened.vendor-reset
  • linuxPackages_latest_xen_dom0.vendor-reset
  • linuxPackages_latest_xen_dom0_hardened.vendor-reset
  • linuxPackages_testing_bcachefs.vendor-reset
  • linuxPackages_xen_dom0.vendor-reset
  • linuxPackages_xen_dom0_hardened.vendor-reset
  • linuxPackages_zen.vendor-reset

@Chiiruno Chiiruno changed the title vendor-reset: init at 0.0.18 linuxPackages.vendor-reset: init at 0.0.18 Nov 29, 2020
lukegb
lukegb approved these changes Nov 29, 2020
View reviewed changes
Copy link
Contributor

@lukegb lukegb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! :)

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 27, 2020 •
edited

Result of nixpkgs-review pr 105280 run on x86_64-linux 1

1 package marked as broken and skipped:
  • linuxPackages_5_8.vendor-reset
1 package failed to build:
  • linuxPackages-libre.vendor-reset
12 packages built:
  • linuxPackages.vendor-reset (linuxPackages_5_4.vendor-reset)
  • linuxPackages_5_9.vendor-reset
  • linuxPackages_hardened.vendor-reset
  • linuxPackages_latest-libre.vendor-reset
  • linuxPackages_latest.vendor-reset
  • linuxPackages_latest_hardened.vendor-reset
  • linuxPackages_latest_xen_dom0.vendor-reset
  • linuxPackages_latest_xen_dom0_hardened.vendor-reset
  • linuxPackages_testing_bcachefs.vendor-reset
  • linuxPackages_xen_dom0.vendor-reset
  • linuxPackages_xen_dom0_hardened.vendor-reset
  • linuxPackages_zen.vendor-reset

Succeeds on manual build.

@Artturin
Copy link
Member

Superseded by #103816

@Artturin Artturin closed this Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Chiiruno @SuperSandro2000 @lukegb @Artturin @Madouura