doc: TeX Live to CommonMark #105270
Merged
doc: TeX Live to CommonMark #105270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <noreply@github.com>
ofborg
bot
added
6.topic: TeX
ryantm
requested changes
Dec 1, 2020
jtojnar
reviewed
Dec 1, 2020
Co-authored-by: Ryan Mulligan <ryan@ryantm.com>
Co-authored-by: Ryan Mulligan <ryan@ryantm.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
jtojnar
reviewed
Dec 1, 2020
Signed-off-by: GitHub <noreply@github.com>
jtojnar
reviewed
Dec 2, 2020
| ```ShellSession | ||
| $ nix repl | ||
| nix-repl> :l <nixpkgs> | ||
| nix-repl> texlive.collection-[TAB] |
There was a problem hiding this comment.
Previously, we had a tab key symbol here (though it does not seem to be properly styled in the current stylesheet). Not sure if we should try to add it.
Otherwise, the diff looks fine and should be ready to merge after squash.
There was a problem hiding this comment.
I think that [TAB] is an improvement over that obscure character.
There was a problem hiding this comment.
The issue is not the textual representation but rather the graphical one. Compare
nix-repl> texlive.collection-→|
with
nix-repl> texlive.collection-[TAB]
There was a problem hiding this comment.
Oh yeah, it looks a lot better with that styling.
ryantm
moved this from Done (add to next Discourse update)
to Completely done
in Conversion to CommonMark Docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no hint about the date and the original author in the XML so I just put the title in the markdown frontmatter