Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.gsconnect: fix installed tests #105272

Merged
merged 1 commit into from Dec 3, 2020
Merged

gnomeExtensions.gsconnect: fix installed tests #105272

merged 1 commit into from Dec 3, 2020

Conversation

mvnetbiz
Copy link
Contributor

Motivation for this change

"try to fix LAN test in gsconnect's installed tests"
https://github.com/NixOS/nixpkgs/projects/30#card-47310308

Things done

add glib-networking to GIO_EXTRA_MODULES of minijasmine of gsconnect test.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 28, 2020
@mvnetbiz
Copy link
Contributor Author

Why should it not use wrapGApp "$installedTests/libexec/installed-tests/gsconnect/minijasmine"?

@ofborg ofborg bot requested a review from etu November 28, 2020 18:50
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105272 run on x86_64-linux 1

1 package built:
  • gnomeExtensions.gsconnect

@jtojnar
Copy link
Contributor

jtojnar commented Nov 28, 2020

I believe it was to limit what dependencies were available in the tests to avoid tests succeeding even though they would fail on live system.

@mvnetbiz
Copy link
Contributor Author

Then glib-networking should probably also be in buildInputs even though it gets installed through other means?

@jtojnar
Copy link
Contributor

jtojnar commented Dec 1, 2020

Yeah, we should probably do that. I guess the daemon inherits the GIO_EXTRA_MODULES variable from the D-Bus activation environment.

@mvnetbiz
Copy link
Contributor Author

mvnetbiz commented Dec 3, 2020

Does this make sense, or should I keep it as wrapProgram? This way the installedTests closure is only 6kb bigger.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 3, 2020

Works for me. Also the commit should say gnomeExtensions.gsconnect (without the 3) so the ofborg can build it.

@mvnetbiz mvnetbiz changed the title gnome3Extensions.gsconnect: fix installed tests gnomeExtensions.gsconnect: fix installed tests Dec 3, 2020
@jtojnar jtojnar merged commit 2fde272 into NixOS:master Dec 3, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Dec 3, 2020

Thanks.

@mvnetbiz mvnetbiz deleted the gsconnect branch December 3, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvnetbiz @SuperSandro2000 @jtojnar