Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.LaTeXML: patch shebangs to use full path to perl on darwin #105271

Merged
merged 2 commits into from Nov 28, 2020
Merged

perlPackages.LaTeXML: patch shebangs to use full path to perl on darwin #105271

merged 2 commits into from Nov 28, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 28, 2020

Motivation for this change

Fixes: #105249

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl requested a review from stigtsp as a code owner November 28, 2020 18:22
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 28, 2020
@xworld21 xworld21 mentioned this pull request Nov 28, 2020
Closed
10 tasks
@SuperSandro2000
Copy link
Member 

ormat error: file is too short
 at /nix/store/swsbd5a4pvzm6sg8dvkxck8qi8vzaasy-perl5.30.3-Archive-Zip-1.68/lib/perl5/site_perl/5.30.3/Archive/Zip/Archive.pm line 1031.
    Archive::Zip::Archive::_findEndOfCentralDirectory(Archive::Zip::Archive=HASH(0x1098168), IO::File=GLOB(0x452c48)) called at /nix/store/swsbd5a4pvzm6sg8dvkxck8qi8vzaasy-perl5.30.3-Archive-Zip-1.68/lib/perl5/site_perl/5.30.3/Archive/Zip/Archive.pm line 761
    Archive::Zip::Archive::readFromFileHandle(Archive::Zip::Archive=HASH(0x1098168), IO::File=GLOB(0x452c48), "931_testor95.epub") called at /nix/store/swsbd5a4pvzm6sg8dvkxck8qi8vzaasy-perl5.30.3-Archive-Zip-1.68/lib/perl5/site_perl/5.30.3/Archive/Zip/Archive.pm line 729
    Archive::Zip::Archive::read(Archive::Zip::Archive=HASH(0x1098168), "931_testor95.epub") called at t/931_epub.t line 35

#   Failed test 'epub file successfully loads as Archive::Zip object'
#   at t/931_epub.t line 35.
#          got: '3'
#     expected: '0'

#   Failed test 'correct number of files were present in final ePub'
#   at t/931_epub.t line 36.
#          got: '0'
#     expected: '10'

#   Failed test 'correct files were present in final ePub: '
#   at t/931_epub.t line 38.

#   Failed test 'log file was written to epub'
#   at t/931_epub.t line 41.
Can't call method "contents" on an undefined value at t/931_epub.t line 42.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 25 just after 7.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105271 run on x86_64-linux 1

2 packages failed to build:
  • perl530Packages.LaTeXML
  • perl532Packages.LaTeXML

@veprbl
Copy link
Member Author

veprbl commented Nov 28, 2020

@GrahamcOfBorg build perl530Packages.LaTeXML
@GrahamcOfBorg build perl532Packages.LaTeXML

@veprbl
Copy link
Member Author

veprbl commented Nov 28, 2020

#105283 was merged, so again:
@GrahamcOfBorg build perl530Packages.LaTeXML
@GrahamcOfBorg build perl532Packages.LaTeXML

stigtsp
stigtsp approved these changes Nov 28, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 105271 run on x86_64-linux 1

2 packages built:
  • perl530Packages.LaTeXML
  • perl532Packages.LaTeXML

Result of nixpkgs-review pr 105271 run on x86_64-darwin 1

2 packages built:
  • perl530Packages.LaTeXML
  • perl532Packages.LaTeXML

Tested bin/latexml* OK on darwin x64

stigtsp
stigtsp requested changes Nov 28, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, premature approval.

bin/latex* executables fails on linux x64

[nix-shell:~/.cache/nixpkgs-review/pr-105271]$ results/perl532Packages.LaTeXML/bin/latexml
/nix/store/93mr9awnj0sb0ca48n1z4ixyyqqrfbbb-coreutils-8.32/bin/env: ‘perl -I/nix/store/03vh3lc5fymqjyck3v3rckbvs36qa74g-perl-5.32.0/lib/perl5/site_perl -I/nix/store/w1kyfhm416v8p8alw5fkd3hxj8d717fv-perl5.32.0-Archive-Zip-1.68/lib/perl5/site_perl -I/nix/st’: No such file or directory
/nix/store/93mr9awnj0sb0ca48n1z4ixyyqqrfbbb-coreutils-8.32/bin/env: use -[v]S to pass options in shebang lines

pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
stigtsp
stigtsp approved these changes Nov 28, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested OK on linux x64 and darwin x64

@stigtsp stigtsp merged commit aed3b7c into NixOS:master Nov 28, 2020
@veprbl veprbl deleted the pr/LaTeXML_darwin_fix branch November 28, 2020 22:05
@veprbl veprbl restored the pr/LaTeXML_darwin_fix branch December 1, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

latexml: binary fails to find LaTeXML::Core
4 participants
@veprbl @SuperSandro2000 @stigtsp @xworld21