Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave-Browser: version updated from 1.16.76 to 1.17.73 #105303

Merged
merged 1 commit into from Nov 29, 2020
Merged

Brave-Browser: version updated from 1.16.76 to 1.17.73 #105303

merged 1 commit into from Nov 29, 2020

Conversation

nasirhm
Copy link
Contributor

@nasirhm nasirhm commented Nov 29, 2020 •
edited

Version updated for Brave Browser to 1.17.73:

  • Added a dependency for libxkbcommon.
  • Updated SHA256 for the version bumped brave browser.

Signed-off-by: nasirhm nasirhussainm14@gmail.com

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from rht and uskudnik November 29, 2020 00:44
@nasirhm
brave: version updated: 1.16.76 -> 1.17.73
1f6d64d 
Version updated for Brave Browser from 1.16.76 to 1.17.73:

- Added a dependency for libxkbcommon.
- Updated SHA256 for the version bumped brave browser.

Signed-off-by: nasirhm <nasirhussainm14@gmail.com>
@nasirhm nasirhm changed the title Brave Browser version updated to 1.17.73 Brave-Browser: version updated from 1.16.76 to 1.17.73 Nov 29, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105303 run on x86_64-linux 1

1 package built:
  • brave

@SuperSandro2000 SuperSandro2000 merged commit ba9a658 into NixOS:master Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht Awaiting requested review from rht

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nasirhm @SuperSandro2000 @Janik-Haag