Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clickhouse: use system LLVM #105286

Merged
merged 1 commit into from Nov 29, 2020
Merged

clickhouse: use system LLVM #105286

merged 1 commit into from Nov 29, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Nov 28, 2020

Motivation for this change

Building LLVM pieces is a huge contributor to build times, and probably
bloats binary size as well. Fortunately, there's a knob for this
specific thing (-DUNBUNDLED=ON seems broken and requires some libraries
which aren't packaged for Nix at the moment).

Hopefully this will make clickhouse able to build on OfBorg.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • Before: /nix/store/y9xf1fq0im7pj7d9xk914l5k4r88hpxi-clickhouse-20.5.2.7 786664240
    • After: /nix/store/4yii8i5ap6miyg5c6hrxas2lmr0cvp0z-clickhouse-20.5.2.7 702939080
    • ~89% in size
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
clickhouse: use system LLVM
6e39a67 
Building LLVM pieces is a huge contributor to build times, and probably
bloats binary size as well. Fortunately, there's a knob for this
specific thing (-DUNBUNDLED=ON seems broken and requires some libraries
which aren't packaged for Nix at the moment).

Hopefully this will make clickhouse able to build on OfBorg.
@lukegb lukegb mentioned this pull request Nov 28, 2020
Closed
10 tasks
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105286 run on x86_64-linux 1

1 package built:
  • clickhouse

@bhipple
Copy link
Contributor

bhipple commented Nov 29, 2020

Really nice to get rid of vendored dependencies!

@bhipple bhipple merged commit 9f84dea into NixOS:master Nov 29, 2020
@lukegb lukegb deleted the clickhouse branch November 29, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukegb @SuperSandro2000 @bhipple