Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdirsyncer: disable flaky test #105277

Merged
merged 1 commit into from Nov 28, 2020
Merged

vdirsyncer: disable flaky test #105277

merged 1 commit into from Nov 28, 2020

Conversation

wirew0rm
Copy link
Contributor

Motivation for this change

Since #103073 the hydra build of vdirsyncer was broken.

Disables sync_test:test_create_collection, a flaky test which exceeds its
deadline and breaks the build on hydra, e.g this hydra build log

Upstream vdirsyncer issue: pimutils/vdirsyncer#837

Since things seem to work for most people, my guess is that it works on beefier machines than my laptop or the hydra builder. I don't know if there is some way to increase the test timeout easily or if this is actually some performance regression.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev fixVdirsyncerTest"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wirew0rm
vdirsyncer: disable flaky test
64a59a0 
Disables sync_test:test_create_collection, a flaky test which exceeds its
deadline and breaks the build on hydra, e.g:
https://hydra.nixos.org/build/130683519/nixlog/1

Upstream vdirsyncer issue: pimutils/vdirsyncer#837
@mweinelt
Copy link
Member

= 1 failed, 369 passed, 115 skipped, 1 deselected, 2601 warnings in 83.70s (0:01:23) =

This does not seem to be a timeout issue and I can't reproduce the error locally.

mweinelt
mweinelt approved these changes Nov 28, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM wrt the upstream issue and the hydra failure vs. me being unable to repro.

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 105277 run on x86_64-linux 1

3 packages built:
  • khal
  • python37Packages.vdirsyncer
  • vdirsyncer (python38Packages.vdirsyncer ,vdirsyncerStable)

@mweinelt mweinelt merged commit e4959b4 into NixOS:master Nov 28, 2020
@ofborg ofborg bot requested a review from loewenheim November 28, 2020 19:36
@wirew0rm wirew0rm deleted the fixVdirsyncerTest branch January 18, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@loewenheim loewenheim Awaiting requested review from loewenheim

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wirew0rm @mweinelt @Janik-Haag