Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh: Disable compiling in /usr/local/... as the site-function directory #105301

Merged
merged 1 commit into from Jan 4, 2021
Merged

zsh: Disable compiling in /usr/local/... as the site-function directory #105301

merged 1 commit into from Jan 4, 2021

Conversation

antifuchs
Copy link
Contributor

Motivation for this change

This addresses #105160.

With the default configure flags, zsh compiles in a reference to the "site function" directory that's outside the store path. Under the right (wrong) circumstances, other builds using zsh can be affected by these functions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@antifuchs
zsh: Disable compiling in /usr/local/... as the site fndir
58fa36d 
With the default configure flags, zsh compiles in a reference to the
"site function" directory that's outside the store path. Under the
right (wrong) circumstances, other builds using zsh can be affected by
these functions.
@ofborg ofborg bot requested a review from pSub November 29, 2020 00:20
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105301 run on x86_64-linux 1

1 package marked as broken and skipped:
  • aliceml
13 packages built:
  • direnv
  • edid-generator
  • gitAndTools.gitstatus
  • grml-zsh-config
  • haskellPackages.hapistrano
  • passExtensions.pass-tomb
  • tomb
  • vimPlugins.direnv-vim
  • zoxide
  • zsh
  • zsh-autosuggestions
  • zsh-powerlevel10k
  • zsh-syntax-highlighting

@doronbehar doronbehar merged commit cf0e547 into NixOS:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antifuchs @SuperSandro2000 @doronbehar