Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kstars: 3.4.3 -> 3.5.0 #104848

Merged
merged 2 commits into from Dec 27, 2020
Merged

kstars: 3.4.3 -> 3.5.0 #104848

merged 2 commits into from Dec 27, 2020

Conversation

hjones2199
Copy link
Member

@hjones2199 hjones2199 commented Nov 25, 2020 •
edited

Motivation for this change

Add new kstars required dependency (stellarsolver) to nixpkgs, and update kstars to 3.5.0. Also updates kstars to use newer version of qt (5.15) and cleans up some mistakes I made in previous update to kstars (deviating from nixpkgs wiki recommendation to use imported mkDerivation instead of wrapQtApps hook).

ksutils.cpp patch also updated to support xplanet binary in the nix store.

Also adding myself as a maintainer to receive pings about kstars, I can force push that out if it's inappropriate.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from TimPut November 25, 2020 03:12
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104848 run on x86_64-linux 1

2 packages built:
  • kstars
  • stellarsolver

@hjones2199 hjones2199 force-pushed the kstars-up branch 2 times, most recently from 602c631 to 87733d0 Compare November 25, 2020 17:27
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104848 run on x86_64-linux 1

2 packages built:
  • kstars
  • stellarsolver

@doronbehar
Copy link
Contributor

@hjones2199 thanks for working on this. Some of your changes were already done, and there's merge conflicts now. If you could please fix them.

@hjones2199
Copy link
Member Author

@hjones2199 thanks for working on this. Some of your changes were already done, and there's merge conflicts now. If you could please fix them.

Thanks for the heads up, rebased onto master and fixed conflicts

@doronbehar doronbehar merged commit 7c304d0 into NixOS:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@doronbehar doronbehar doronbehar requested changes

@TimPut TimPut Awaiting requested review from TimPut

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hjones2199 @SuperSandro2000 @doronbehar