Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyscard: Remove patch that is included in 1.9.9 and 2.0.0 #104823

Merged
merged 1 commit into from Nov 25, 2020
Merged

pythonPackages.pyscard: Remove patch that is included in 1.9.9 and 2.0.0 #104823

merged 1 commit into from Nov 25, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#102846

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 24, 2020
Merged
10 tasks
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 104823 run on x86_64-linux 1

@SuperSandro2000
Copy link
Member Author

On darwin I get

  WARNING: The directory '/homeless-shelter/Library/Caches/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
  Collecting git+https://github.com/Yubico/yubikey-manager.git (from -r requirements.txt (line 1))
    Cloning https://github.com/Yubico/yubikey-manager.git to /private/tmp/nix-build-yubioath-desktop-5.0.4.drv-0/pip-req-build-l2b1ssc4
    ERROR: Error [Errno 2] No such file or directory: 'git' while executing command git clone -q https://github.com/Yubico/yubikey-manager.git /private/tmp/nix-build-yubioath-desktop-5.0.4.drv-0/pip-req-build-l2b1ssc4
  ERROR: Cannot find command 'git' - do you have 'git' installed and in your PATH?
  make: *** [Makefile:437: pymodules] Error 1
  make: *** Waiting for unfinished jobs....
cannot build derivation '/nix/store/pz6gryhgnm71gycb03vm2i4gp7nr80nc-env.drv': 2 dependencies couldn't be built
[11 built (2 failed), 134 copied (760.0 MiB), 177.6 MiB DL]
error: build of '/nix/store/pz6gryhgnm71gycb03vm2i4gp7nr80nc-env.drv' failed

which is totally unrelated to this PR.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 25, 2020
Closed
@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Nov 25, 2020 •
edited

Result of nixpkgs-review pr 104823 run on x86_64-darwin 1

2 packages failed to build:
  • electrum
  • yubioath-desktop
12 packages built:
  • gen-oath-safe
  • hwi (python38Packages.hwi)
  • python27Packages.btchip
  • python27Packages.pyscard
  • python37Packages.btchip
  • python37Packages.emv
  • python37Packages.hwi
  • python37Packages.pyscard
  • python38Packages.btchip
  • python38Packages.emv
  • python38Packages.pyscard
  • yubikey-manager

@ofborg ofborg bot requested a review from layus November 25, 2020 00:15
layus
layus approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@layus layus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on linux.

@layus
Copy link
Member

layus commented Nov 25, 2020

@FRidh, @jonringer This one is a no-brainer and can be merged immediately :-).

jonringer
jonringer approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 104823 1

@jonringer jonringer merged commit e204319 into NixOS:master Nov 25, 2020
@SuperSandro2000 SuperSandro2000 deleted the pyscard-darwin branch November 26, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layus layus layus approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @layus @jonringer