Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 0c6fc3c05e1d
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 2b884eb9f698
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 24, 2020

  1. factorio: fail fetch early if no credentials provided 

    The download URL will redirect to the login page if credentials are not
present, but will return an error if the credentials are wrong.

Since we know we always expect credentials, we can fail the fetch in
the preHook if they're not provided.

We can't use e.g. builtins.throw because we want the fetchurl derivation
to be evaluated in all cases - because that's the mechanism which allows
you to just manually add the tarball to the Nix store.
    @lukegb
    lukegb committed Nov 24, 2020
    Copy the full SHA
    86aa2a5 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #104732 from lukegb/factorio-fail-if-no-creds 

    factorio: fail fetch early if no credentials provided
    @prusnak
    prusnak committed Nov 24, 2020
    Copy the full SHA
    2b884eb View commit details
    Browse the repository at this point in the history