unison-ucm 1.0.M1l-alpha -> 1.0.M1m-alpha #104809
Conversation
| @@ -24,7 +24,7 @@ stdenv.mkDerivation rec { | |||
| dontConfigure = true; | |||
|
|
|||
| nativeBuildInputs = stdenv.lib.optional (!stdenv.isDarwin) autoPatchelfHook; | |||
| buildInputs = stdenv.lib.optionals (!stdenv.isDarwin) [ ncurses5 zlib gmp ]; | |||
| buildInputs = [ less ] ++ (stdenv.lib.optionals (!stdenv.isDarwin) [ ncurses5 zlib gmp ]); | |||
There was a problem hiding this comment.
Does it really link against less?
There was a problem hiding this comment.
no, but it uses it at runtime, and this is the way i know to make it available in a pure shell.
Better approaches welcomed :)
There was a problem hiding this comment.
makeWrapper would be a good fit here.
There was a problem hiding this comment.
Sorry, I don't follow. A quick glance at both make_wrapper.sh and docs doesn't really help me understand what you mean. Do you have an example you can point me to?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah great, thanks! Updated and tested that it works correctly in a pure shell.
|
Result of 1 package built:
|
|
Result of 1 package built:
|
See title. Also, add missing `less` to buildInputs
virusdave
force-pushed
the
dnicponski/scratch/update_ucm
branch
from
064d1b0
to
1a1e0f0
Compare
See title. Also, add missing
lessto buildInputs.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)