Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bat: 0.17.0 -> 0.17.1 #104804

Merged
merged 1 commit into from Nov 24, 2020
Merged

bat: 0.17.0 -> 0.17.1 #104804

merged 1 commit into from Nov 24, 2020

Conversation

06kellyjac
Copy link
Member

Motivation for this change

Bump bat to 0.17.1

Maintainer ping:
@dywedir @lilyball @zowoq

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 104804 1

7 packages built:
  • bat
  • bat-extras.batdiff
  • bat-extras.batgrep
  • bat-extras.batman
  • bat-extras.batwatch
  • bat-extras.prettybat
  • neuron-notes

@ofborg ofborg bot requested review from dywedir, lilyball and zowoq November 24, 2020 21:17
@dywedir
Copy link
Member

dywedir commented Nov 24, 2020

Thanks!

@dywedir dywedir merged commit 9da2428 into NixOS:master Nov 24, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104804 run on x86_64-darwin 1

8 packages built:
  • bat
  • bat-extras.batdiff
  • bat-extras.batgrep
  • bat-extras.batman
  • bat-extras.batwatch
  • bat-extras.prettybat
  • haskellPackages.neuron
  • neuron-notes

@06kellyjac 06kellyjac deleted the bat branch November 24, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir Awaiting requested review from dywedir

@lilyball lilyball Awaiting requested review from lilyball

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@06kellyjac @dywedir @SuperSandro2000