Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plex-media-player: remove myself as a maintainer #104863

Merged

Conversation

kylewlacy
Copy link
Contributor

Motivation for this change

I jumped on the Nix train some years ago, but since then I've stepped away from the ecosystem at large. Since then, my situation is pretty different, and it's hard for me to find the time to review even minor changes these days (however sporadic). As such, I don't want to give the false impression that I can act as an active maintainer for the package, so I think it's best if I remove myself from the maintainers list.

@B4dM4n I know you've done some version bumps and done general maintenance on plex-media-player... I don't want to impose, but would you be interested in picking it up?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RaghavSood RaghavSood merged commit 342ec6f into NixOS:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants