Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx: 1.19.4 -> 1.19.5 #104819

Merged
merged 1 commit into from Nov 27, 2020
Merged

nginx: 1.19.4 -> 1.19.5 #104819

merged 1 commit into from Nov 27, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 24, 2020

Motivation for this change

Upstream release: https://nginx.org/en/CHANGES

Now allows settings the error log via command line (with -e).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 requested a review from Izorkin November 24, 2020 23:32
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104819 run on x86_64-linux 1

1 package built:
  • nginxMainline

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104819 run on x86_64-darwin 1

1 package built:
  • nginxMainline

@ajs124 ajs124 merged commit e0ba6d3 into NixOS:master Nov 27, 2020
@ajs124 ajs124 deleted the upd/nginx branch November 27, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Izorkin Izorkin Awaiting requested review from Izorkin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @SuperSandro2000