Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devede: 4.8.8 -> 4.16.0, move to GitLab #104806

Merged
merged 1 commit into from Nov 24, 2020
Merged

devede: 4.8.8 -> 4.16.0, move to GitLab #104806

merged 1 commit into from Nov 24, 2020

Conversation

va1entin
Copy link
Contributor

Motivation for this change
  • Devede was moved to GitLab, see archived GitHub repo
  • Since the move to GitLab new releases were made
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Nov 24, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the commits together?

pkgs/applications/video/devede/default.nix Show resolved Hide resolved
pkgs/applications/video/devede/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from bdimcheff November 24, 2020 21:47
@va1entin
devede: move to GitLab, 4.8.8 -> 4.16.0
edd823b 
devede: 4.8.8 -> 4.16.0

use pname and version
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104806 run on x86_64-linux 1

1 package built:
  • devede

@va1entin
Copy link
Contributor Author

Thanks for the feedback! I've adressed your feedback and squashed the commits afterwards.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104806 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • devede

@SuperSandro2000 SuperSandro2000 merged commit 8aedb34 into NixOS:master Nov 24, 2020
@va1entin va1entin deleted the devede_update branch November 25, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdimcheff bdimcheff Awaiting requested review from bdimcheff

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@va1entin @SuperSandro2000