Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vips: add librsvg dependency #104855

Merged
merged 1 commit into from Nov 25, 2020
Merged

vips: add librsvg dependency #104855

merged 1 commit into from Nov 25, 2020

Conversation

jekor
Copy link
Contributor

@jekor jekor commented Nov 25, 2020

Some vips operations on SVG files require librsvg.

Motivation for this change

Certain operations by the npm sharp package which uses vips will fail (with a confusing message about magick) with librsvg.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jekor
vips: add librsvg dependency
f2b2eb2 
Some vips operations on SVG files require librsvg.
@ofborg ofborg bot requested a review from KoviRobi November 25, 2020 03:57
@SuperSandro2000
Copy link
Member

Is there an easy test case to check if this actually worked?

@jekor
Copy link
Contributor Author

jekor commented Nov 25, 2020

I don't have a small one. You can see my comments on 101arrowz/pwa-manifest#16 for the test I did. I still don't understand the flow of the code in pwa-manifest to produce a minimal test case.

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 104855 1

2 packages failed to build:
  • joplin
  • photoflow
9 packages built:
  • imgproxy
  • nip2
  • python27Packages.pyvips
  • python37Packages.pyvips
  • python38Packages.pyvips
  • rubyPackages.ruby-vips (rubyPackages_2_6.ruby-vips)
  • rubyPackages_2_5.ruby-vips
  • rubyPackages_2_7.ruby-vips
  • vips

@RaghavSood RaghavSood mentioned this pull request Nov 25, 2020
Merged
10 tasks
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 25, 2020 •
edited

Result of nixpkgs-review pr 104855 run on x86_64-linux 1

1 package marked as broken and skipped:
  • photoflow
1 package failed to build:
  • joplin
9 packages built:
  • imgproxy
  • nip2
  • python27Packages.pyvips
  • python37Packages.pyvips
  • python38Packages.pyvips
  • rubyPackages.ruby-vips (rubyPackages_2_6.ruby-vips)
  • rubyPackages_2_5.ruby-vips
  • rubyPackages_2_7.ruby-vips
  • vips

joplin:

hash mismatch in fixed-output derivation '/nix/store/s3m0az7br2yfnpc45rzf8n0kajj7ii6j-node-emoji-9fa01ea':                                                                                    wanted: sha256:18yqfrjiwxkc19v7h419aj2g351pxbapb41na30qg5m45154568l                                                                                                                         got:    sha256:01k421l356bgnydlwrvzlnqrkdygq1fscjiwpmyw6l2i83650j92                                                                                                                       hash mismatch in fixed-output derivation '/nix/store/8hpdg4spzsjbhclgh11gvfvsvd8cvz68-uslug-ba2834d':                                                                                         wanted: sha256:0n82ps8l1qj22nyqhkhpblfap04j4sz7ai654drs0li0mhzl2r4z                                                                                                                         got:    sha256:12847zhxnv3p3nnxcywg81qdhpaj1p58jgxsips0mym8aqj1fg72                                                                                                                       cannot build derivation '/nix/store/wm2j3mla7mxw58zxk5vxlivf9b18hgq0-node_joplin-1.4.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/2pgv1f8kybnsg88siscjyqlmlcbc4w0n-env.drv': 1 dependencies couldn't be built

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104855 run on x86_64-darwin 1

6 packages built:
  • imgproxy
  • nip2
  • python27Packages.pyvips
  • python37Packages.pyvips
  • python38Packages.pyvips
  • vips

@SuperSandro2000 SuperSandro2000 merged commit 1b4fe07 into NixOS:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoviRobi KoviRobi Awaiting requested review from KoviRobi

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jekor @SuperSandro2000 @RaghavSood