[MSE][webcodecs] Plumb AddSourceBufferUsingConfig to ChunkDemuxer AddId #26642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 25, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2548844
branch
3 times, most recently
from
935bcc4
to
c13a481
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2548844
branch
3 times, most recently
from
0b0e459
to
7d22837
Compare
This change:
1) Exposes as static synchronous helpers the WebCodecs MakeMediaConfig
methods' internals so that MediaSource can use them to obtain
media::{Audio,Video}DecoderConfigs from WebCodecs
{Audio,Video}DecoderConfigs.
2) Implements MediaSource::AddSourceBufferUsingConfig for encoded
configs (not decodedMediaType), plumbing the media decoder config
through the usual steps in MSE addSourceBuffer, and through new
methods in WebMediaSource and WebMediaSourceImpl to let
ChunkDemuxer::AddId know it will be expected to handle WebCodecs
encoded chunk appends for the associated SourceBuffer.
3) Adds a tentative folder for MSE-for-WebCodecs web_tests and adds
a test for the current behavior of addSourceBuffer(webcodecs decoder
config) that this CL adds.
Later changes will continue plumbing of the configs in ChunkDemuxer and
SourceBufferState, and also add implementations and ChunkDemuxer/etc
support for appendEncoded{Audio,Video}Chunks. The h264 parser and avcc
conditionally created in #1, above, could then be used by SourceBuffer
processing of appended EncodedVideoChunks, too.
BUG=1144908
Change-Id: I90c1d90c3a28d5cc1e33b1e50e32f4cfea639784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548844
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835058}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2548844
branch
from
7d22837
to
d02d9bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
Exposes as static synchronous helpers the WebCodecs MakeMediaConfig
methods' internals so that MediaSource can use them to obtain
media::{Audio,Video}DecoderConfigs from WebCodecs
{Audio,Video}DecoderConfigs.
Implements MediaSource::AddSourceBufferUsingConfig for encoded
configs (not decodedMediaType), plumbing the media decoder config
through the usual steps in MSE addSourceBuffer, and through new
methods in WebMediaSource and WebMediaSourceImpl to let
ChunkDemuxer::AddId know it will be expected to handle WebCodecs
encoded chunk appends for the associated SourceBuffer.
Adds a tentative folder for MSE-for-WebCodecs web_tests and adds
a test for the current behavior of addSourceBuffer(webcodecs decoder
config) that this CL adds.
Later changes will continue plumbing of the configs in ChunkDemuxer and
SourceBufferState, and also add implementations and ChunkDemuxer/etc
support for appendEncoded{Audio,Video}Chunks. The h264 parser and avcc
conditionally created in #1, above, could then be used by SourceBuffer
processing of appended EncodedVideoChunks, too.
BUG=1144908
Change-Id: I90c1d90c3a28d5cc1e33b1e50e32f4cfea639784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548844
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835058}