Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to improve selection-[ input | textarea ]-011 reference files #26641

Merged
merged 2 commits into from Jan 22, 2021

Conversation

TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Nov 24, 2020

reference/selection-input-011-ref.html
reference/selection-textarea-011-ref.html

The improvements in this PR are of the same nature
as in: #26245

Browsers (Chromium, Firefox, Safari) do not behave exactly the same when select()-ing form control elements like a text input or a textarea.

The code involved in this PR aims at flattening, smoothing out the differences.

We deliberately focus the form controls (text input,
textarea) in the reference files (with focus()) hoping
to trigger the same user agent style sheet rule that
governs, that styles focusable elements, for example:

:focus {outline: -webkit-focus-ring-color auto 1px;}

which can be found in Chromium-based browsers.

Over at my website, the correspondent files are:

http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/selection-input-011-newer.html

http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/reference/selection-input-011-ref-newer.html

http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/selection-textarea-011-newer.html

http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/reference/selection-textarea-011-ref-newer.html

@TalbotG TalbotG self-assigned this Nov 24, 2020
@TalbotG TalbotG removed the request for review from plinss November 24, 2020 23:25
@TalbotG
Copy link
Contributor Author

TalbotG commented Jan 20, 2021

Issue 1110495: Selection rect in <input> seems off by a few pixels
https://bugs.chromium.org/p/chromium/issues/detail?id=1110495

@tkent-google tkent-google merged commit b28d040 into web-platform-tests:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants