Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: use withPortabled in mesonFlags #104818

Merged
merged 1 commit into from Nov 24, 2020
Merged

systemd: use withPortabled in mesonFlags #104818

merged 1 commit into from Nov 24, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Nov 24, 2020 •
edited

No matter what withPortabled was being set, we always passed
-Dportabled=false in mesonFlags. Fix this.

Also, nixpkgs-fmt the file for consistency.

This contains zero changes, so no rebuild and targetting master. I verified it applies cleanly with what's currently in staging and staging-next.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
systemd: use withPortabled in mesonFlags
b92942f 
No matter what withPortabled was being set, we always passed
-Dportabled=false in mesonFlags. Fix this.

Also, nixpkgs-fmt the file for consistency.
aanderse
aanderse approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straight forward 👍

@flokli flokli merged commit f55c180 into NixOS:master Nov 24, 2020
@flokli flokli deleted the systemd-with-portabled-mesonflags branch November 24, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@arianvp arianvp Awaiting requested review from arianvp

@andir andir Awaiting requested review from andir

@picnoir picnoir Awaiting requested review from picnoir

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @aanderse