Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmountains: init at 2.1 #103518

Merged
merged 2 commits into from Jan 18, 2021
Merged

xmountains: init at 2.1 #103518

merged 2 commits into from Jan 18, 2021

Conversation

djanatyn
Copy link
Contributor

Motivation for this change

This is a fractal image generator for X11. The algorithms it uses are well documented.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I added a new license, hpndSellVariant, after identifying copyright.h.

There are no tags in the repository. The version (2.10) is taken from the latest commit:

$ git show --no-patch aa3bcbfed228adf3fff0fe4295589f13fc194f0b
commit aa3bcbfed228adf3fff0fe4295589f13fc194f0b (HEAD -> master, origin/master, origin/HEAD)
Author: Stephen Booth <s.booth@epcc.ed.ac.uk>
Date:   Fri Jul 24 11:12:21 2020 +0100

    Version 2.10

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is my machine or the package:

configuring
configuring with imake: ''
imake -DUseInstalled -I/nix/store/xj92pflviva2kd0frrq6ya40pcnryhgq-imake-1.0.8/lib/X11/config
/nix/store/xj92pflviva2kd0frrq6ya40pcnryhgq-imake-1.0.8/bin/xmkmf: line 53:    13 Aborted                 (core dumped) imake $imake_defines $args

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 103518 run on x86_64-linux 1

1 package built:
  • xmountains

@SuperSandro2000 SuperSandro2000 merged commit c73cb2b into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants