Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom-us: support alsa #103485

Merged
merged 1 commit into from Nov 21, 2020
Merged

zoom-us: support alsa #103485

merged 1 commit into from Nov 21, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 11, 2020

Motivation for this change

So zoom-us supports pure alsa setups

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from jonringer November 12, 2020 01:15
Comment on lines 10 to +11
, pulseaudioSupport ? true, libpulseaudio ? null
, alsaSupport ? stdenv.isLinux, alsaLib ? null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I like this default value. For most Linux users pulseaudioSupport is enough.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doronbehar That's not true. We have no hardware.pulseaudio.enable = true; by default. Also a lot of packages support bare ALSA setups by default, so zoom-us should too. Also makes no harm, since zoom sees both. Will use pulseaudio by default but fallback to alsa if pulseaudio is not running

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right.. It won't increase the closure size as well I suppose.

@ghost
Copy link
Author

ghost commented Nov 20, 2020

Everything works for both alsa and pulseaudio users after this PR
Screenshots
alsa
alsa
pulse
pulse

Copy link
Contributor

@tadfisher tadfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, won't hurt anything.

@doronbehar doronbehar merged commit 7bea3c7 into NixOS:master Nov 21, 2020
@ghost
Copy link
Author

ghost commented Nov 21, 2020

@doronbehar Thank you!

@ghost ghost deleted the zoom-us branch November 22, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants