New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zoom-us: support alsa #103485
zoom-us: support alsa #103485
Conversation
pkgs/applications/networking/instant-messengers/zoom-us/default.nix
Outdated
Show resolved
Hide resolved
, pulseaudioSupport ? true, libpulseaudio ? null | ||
, alsaSupport ? stdenv.isLinux, alsaLib ? null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if I like this default value. For most Linux users pulseaudioSupport is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doronbehar That's not true. We have no hardware.pulseaudio.enable = true;
by default. Also a lot of packages support bare ALSA setups by default, so zoom-us should too. Also makes no harm, since zoom sees both. Will use pulseaudio by default but fallback to alsa if pulseaudio is not running
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right.. It won't increase the closure size as well I suppose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, won't hurt anything.
@doronbehar Thank you! |
Motivation for this change
So zoom-us supports pure alsa setups
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)