[20.09] pythonPackages.py-multihash: 0.2.3 -> 1.0.0 #103468
Merged
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Nov 12, 2020
There was a problem hiding this comment.
the "broken = true;" also needs to be removed:
$ nix-build -A python3Packages.py-multihash
error: Package ‘python3.8-py-multihash-0.2.3’ in /home/jon/projects/nixpkgs/pkgs/development/python-modules/py-multihash/default.nix:45 is marked as broken, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
(use '--show-trace' to show detailed location information)
(cherry picked from commit dd7b6a5)
IvarWithoutBones
force-pushed
the
fix-multihash-20.09
branch
from
91ed2c7 to
6d068f0
Compare
Totally forgot about that, my bad. I've removed that, should be ready to merge now. |
|
Result of 2 packages built:
|
mweinelt
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit dd7b6a5)
original PR: #101801
Motivation for this change
Package fails to build without this.
cc @mweinelt
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)