Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

davfs2: 1.5.6 -> 1.6.0, unison: 2.51.2 -> 2.51.3 #103453

Merged
merged 3 commits into from Nov 11, 2020
Merged

davfs2: 1.5.6 -> 1.6.0, unison: 2.51.2 -> 2.51.3 #103453

merged 3 commits into from Nov 11, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 11, 2020

Motivation for this change

A few things I needed to implement a better syncing strategy without nextcloud-client, but with unison and davfs2:

  • Removed myself from the maintainer-list of nextcloud-client as I no longer intend to use this.
  • Update davfs2 to 1.6.0 and added a patch to make sure that umount is properly invoked.
  • Update unison to 2.51.3.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested review from flokli, LnL7 and jtojnar November 11, 2020 13:54
@ofborg ofborg bot requested a review from viric November 11, 2020 14:05
@flokli
Copy link
Contributor

flokli commented Nov 11, 2020

Result of nixpkgs-review pr 103453 1

3 packages built:
  • davfs2
  • unison
  • usync

@flokli flokli merged commit 4df6d2d into NixOS:master Nov 11, 2020
@Ma27 Ma27 deleted the dav-unison-sync branch November 11, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@LnL7 LnL7 Awaiting requested review from LnL7

@jtojnar jtojnar Awaiting requested review from jtojnar

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @flokli